From: Florian Müllner <fmuellner@gnome.org>
Date: Thu, 17 Jun 2021 13:42:14 +0000 (+0200)
Subject: shellDBus: Properly return from D-Bus methods
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~574^2^2~251
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=158920924df53198e85d997b33b6e05afb93f2e8;p=gnome-shell.git

shellDBus: Properly return from D-Bus methods

When implementing a D-Bus method synchronously, regular JS methods are
used. That is, whatever the method returns is passed as return value
to the method invocation.

However for asynchronous implementations, we need to explicitly return
a value to the invocation, otherwise the caller will wait until it times
out eventually.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1891>
---

diff --git a/js/ui/shellDBus.js b/js/ui/shellDBus.js
index 48e7bb5b8..6574cc528 100644
--- a/js/ui/shellDBus.js
+++ b/js/ui/shellDBus.js
@@ -217,11 +217,13 @@ var GnomeShell = class {
         let sender = invocation.get_sender();
         let [dict] = params;
         Main.osdMonitorLabeler.show(sender, dict);
+        invocation.return_value(null);
     }
 
     HideMonitorLabelsAsync(params, invocation) {
         let sender = invocation.get_sender();
         Main.osdMonitorLabeler.hide(sender);
+        invocation.return_value(null);
     }
 
     _checkOverviewVisibleChanged() {